Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented May 13, 2024

Open in Gitpod know more

Describe your change:

I added tests for NumberOfSubsetEqualToGivenSum. The current implementation does not handle properly inputs less or equal 0, so I decided to explicitly throw an error for such inputs.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@vil02 vil02 marked this pull request as ready for review May 13, 2024 20:08
@vil02 vil02 force-pushed the test_NumberOfSubsetEqualToGivenSum branch from bc6e8c6 to 3ac14a0 Compare May 13, 2024 20:14
@raklaptudirm raklaptudirm merged commit 1554ba5 into TheAlgorithms:master May 25, 2024
@vil02 vil02 deleted the test_NumberOfSubsetEqualToGivenSum branch May 25, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants