Skip to content

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented Mar 18, 2024

Open in Gitpod know more

Describe your change:

As promissed, this PR adds a function parseDate.

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@vil02 vil02 marked this pull request as ready for review March 18, 2024 16:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (bd34e9f) to head (efeab6e).

Additional details and impacted files
@@ Coverage Diff @@ ## master #1643 +/- ## ======================================= Coverage 84.07% 84.07% ======================================= Files 375 376 +1 Lines 19688 19694 +6 Branches 2913 2907 -6 ======================================= + Hits 16552 16558 +6  Misses 3136 3136 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

appgurueu
appgurueu previously approved these changes Mar 26, 2024
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

(Though probably these date-related functions should take "date" objects instead of strings in the first place to save them the (not very interesting) parsing.)

Co-authored-by: appgurueu <34514239+appgurueu@users.noreply.github.com>
@raklaptudirm raklaptudirm merged commit 9c622dd into TheAlgorithms:master Apr 3, 2024
@vil02 vil02 deleted the add_parse_date branch April 3, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants