Skip to content

Conversation

@gmottajr
Copy link
Contributor

@gmottajr gmottajr commented Jan 4, 2024

Issue 425 - Migrate to DotNet 8 - File-scoped namespaces:

Algorithms --> Sorters and Strings.

Motivation and Context

Github issue #425: Proposed to update to File-scoped namespaces. It was requested to perform the changes in a few PRs to make them smaller and easier to review. This is the one only meant to update .NET version.

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
Sorters Strings Switch to file-scoped namespaces Issue 425 - Migrate to DotNet 8
@gmottajr gmottajr requested a review from siriak as a code owner January 4, 2024 17:44
@codecov
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (691d270) 94.42% compared to head (965d7ef) 94.48%.

Files Patch % Lines
Algorithms/Sorters/Comparison/TimSorter.cs 94.09% 12 Missing and 6 partials ⚠️
Algorithms/Strings/Similarity/JaroSimilarity.cs 94.87% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #433 +/- ## ========================================== + Coverage 94.42% 94.48% +0.06%  ========================================== Files 234 234 Lines 9843 9843 Branches 1455 1455 ========================================== + Hits 9294 9300 +6  + Misses 387 384 -3  + Partials 162 159 -3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit a354d01 into TheAlgorithms:master Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants