Skip to content

fix: cleanup longest_common_string.cpp #2462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Panquesito7 merged 20 commits into from
Jul 4, 2023
Merged

fix: cleanup longest_common_string.cpp #2462

Panquesito7 merged 20 commits into from
Jul 4, 2023

Conversation

@vil02
Copy link
Member

@vil02 vil02 commented May 12, 2023 •
edited
Loading

Description of Change

The file longest_common_string.cpp does not even compile. This PR fixes the implementation of the longest common string.

Checklist

  • Added description of change
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:
Makes longest_common_string.cpp work.
realstealthninja
realstealthninja requested changes May 23, 2023
View reviewed changes
realstealthninja
realstealthninja requested changes May 24, 2023
View reviewed changes
@vil02 vil02 requested a review from realstealthninja May 24, 2023 19:19
realstealthninja
realstealthninja requested changes May 25, 2023
View reviewed changes
realstealthninja
realstealthninja requested changes May 30, 2023
View reviewed changes
@vil02 vil02 requested a review from realstealthninja May 31, 2023 05:17
realstealthninja
realstealthninja requested changes May 31, 2023
View reviewed changes
@realstealthninja realstealthninja mentioned this pull request May 31, 2023
Closed
8 tasks
@vil02 vil02 requested a review from realstealthninja May 31, 2023 13:59
@Panquesito7 Panquesito7 added the enhancement New feature or request label May 31, 2023
Panquesito7
Panquesito7 requested changes Jun 1, 2023
View reviewed changes
@vil02 vil02 requested a review from Panquesito7 June 3, 2023 19:27
Panquesito7
Panquesito7 approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing. Thanks! 🚀
realstealthninja
realstealthninja approved these changes Jun 16, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
realstealthninja
realstealthninja requested changes Jun 16, 2023
View reviewed changes
realstealthninja
realstealthninja previously approved these changes Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wish there was more documentation but what can you do when people dont comply 🤷‍♀️
Panquesito7
Panquesito7 previously approved these changes Jun 20, 2023
View reviewed changes
@vil02 vil02 dismissed stale reviews from Panquesito7 and realstealthninja via 25f4ede June 21, 2023 21:05
Panquesito7
Panquesito7 reviewed Jun 23, 2023
View reviewed changes
Panquesito7
Panquesito7 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks! 🚀
realstealthninja
realstealthninja approved these changes Jun 24, 2023
View reviewed changes
Copy link
Collaborator

@realstealthninja realstealthninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
@Panquesito7 Panquesito7 merged commit 32db99c into TheAlgorithms:master Jul 4, 2023
@vil02 vil02 deleted the longest_common_string_patch branch July 4, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@vil02 @Panquesito7 @realstealthninja