Skip to content

Conversation

@Jxtopher
Copy link
Contributor

@Jxtopher Jxtopher commented Jul 11, 2021

Description of Change

Solving magic sequence problem with a backtracking.

@mishraabhinn mishraabhinn added automated tests are failing Do not merge until tests pass enhancement New feature or request good first issue Good for newcomers labels Jul 11, 2021
@Panquesito7 Panquesito7 removed the automated tests are failing Do not merge until tests pass label Jul 12, 2021
@Panquesito7 Panquesito7 changed the title Solving magic sequence problem with a backtracking. feat: solving magic sequence problem with backtracking Jul 12, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your functions and namespaces are missing documentation. Please check the typical structure of a program for how to make your code properly.

@Panquesito7 Panquesito7 added Proper Documentation Required requested to write the documentation properly requested changes changes have been requested labels Jul 12, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good work!

Jxtopher and others added 9 commits July 13, 2021 13:25
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@Jxtopher
Copy link
Contributor Author

Thank you for these improvements :)

Jxtopher and others added 6 commits July 13, 2021 22:56
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 😄

Jxtopher and others added 4 commits July 14, 2021 08:13
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there; good work! 😄

Jxtopher and others added 6 commits July 15, 2021 12:13
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your patience, dedication, and contributions to our community! 😄 👍 🎉

Join our Discord server to stay tuned about new announcements, engage with our community, help others with their problems, and much more.
You can also ask for the Contributor in the #privs-role-requests channel role once this PR is merged. 🙂

@Panquesito7 Panquesito7 removed Proper Documentation Required requested to write the documentation properly requested changes changes have been requested labels Jul 16, 2021
@Panquesito7 Panquesito7 added the approved Approved; waiting for merge label Jul 16, 2021
@Jxtopher
Copy link
Contributor Author

Thank you for all the improvements proposed and this dynamic in the proposals.

@ayaankhan98 ayaankhan98 merged commit ae8685f into TheAlgorithms:master Jul 17, 2021
sthagen added a commit to sthagen/TheAlgorithms-C-Plus-Plus that referenced this pull request Jul 17, 2021
feat: solving magic sequence problem with backtracking (TheAlgorithms#1533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved; waiting for merge enhancement New feature or request good first issue Good for newcomers

4 participants