Skip to content

Conversation

@bharath000
Copy link
Contributor

Description of Change

feat: Trie data structure using hashmap, predict_words method to recommend words based on a given prefix.

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@lgtm-com

This comment has been minimized.

Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix clang-tidy warnings.

@Panquesito7 Panquesito7 added automated tests are failing Do not merge until tests pass enhancement New feature or request requested changes changes have been requested labels Mar 12, 2021
@Panquesito7 Panquesito7 removed the automated tests are failing Do not merge until tests pass label Mar 13, 2021
Panquesito7
Panquesito7 previously approved these changes Mar 17, 2021
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work; I like how you've made & improved the code so well! 🎉
Code and documentation look good and very refined; LGTM. 😄 👍

@Panquesito7 Panquesito7 added approved Approved; waiting for merge and removed requested changes changes have been requested labels Mar 17, 2021
@Panquesito7 Panquesito7 requested a review from ayaankhan98 March 17, 2021 21:26
@ayaankhan98
Copy link
Member

@bharath000 please mark the considered changes as resolved.

@Panquesito7 Panquesito7 requested a review from ayaankhan98 March 18, 2021 17:39
Copy link
Member

@ayaankhan98 ayaankhan98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bharath000 Thanks for your contribution.

@ayaankhan98 ayaankhan98 merged commit 7ea1ca6 into TheAlgorithms:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Approved; waiting for merge enhancement New feature or request

3 participants