Added heavy_light_decomposition.cpp #1016

aneee004 · 2020-08-13T17:53:07Z

Description of Change

Added a new file heavy_light_decomposition.cpp, which supports point updates and path queries in a tree. The implementation is completely original, and implemented from scratch.

Checklist

Added description of change
Added file name matches File name guidelines
Added tests and example, test must pass
Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
Relevant documentation/comments is changed or added
PR title follows semantic commit guidelines
Search previous suggestions before making a new one, as yours may be a duplicate.
I acknowledge that all my contributions will be made under the project's license.

Notes: Adding an implementation of Heavy-Light decomposition.

Added heavy_light_decomposition.cpp

range_queries/heavy_light_decomposition.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

TODO: Data member documentation.

Added function documentation

range_queries/heavy_light_decomposition.cpp

Function documentation

range_queries/heavy_light_decomposition.cpp

Edited comments

range_queries/heavy_light_decomposition.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7

Please enable GitHub Actions in your fork of this repository for refined code and formatting.

range_queries/heavy_light_decomposition.cpp

Added wiki

aneee004 · 2020-08-13T21:49:36Z

Please enable GitHub Actions in your fork of this repository for refined code and formatting.

I'm not sure I did it right. Should I get any specific action from the marketplace?

Panquesito7 · 2020-08-13T22:06:51Z

Never mind, it seems GitHub Actions is already enabled. 😄

.github/workflows/c-cpp.yml

aneee004 · 2020-08-14T22:55:51Z

Thank you for your time and guidance. Learnt a lot about writing refined code and proper documentation.

Looking forward to contributing more to this repository!

kvedala

Looks good 👍 Just some doc corrections.

Before you commit, please enable the "GitHub Actions" on this repo. See the image below - only the enable button needs to be clicked, all the settings are already in place.

range_queries/heavy_light_decomposition.cpp

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>

aneee004 · 2020-08-15T14:57:34Z

Looks good +1 Just some doc corrections.

Before you commit, please enable the "GitHub Actions" on this repo. See the image below - only the enable button needs to be clicked, all the settings are already in place.

I think I already have this enabled.

kvedala · 2020-08-15T15:50:01Z

Looks good +1 Just some doc corrections.
Before you commit, please enable the "GitHub Actions" on this repo. See the image below - only the enable button needs to be clicked, all the settings are already in place.

I think I already have this enabled.

Your code includes "tab-space" indentation which is disabled in the repo. Other formatting options are also not being seen. The Github Actions settings for this repo should have corrected that.

aneee004 · 2020-08-15T15:53:40Z

Does this look right? (Bear with me, I'm a little new around here).

A screenshot of my fork.

Never mind, it seems GitHub Actions is already enabled.

@Panquesito7 said that it was enabled. I'm not sure what the issue is.

kvedala · 2020-08-15T15:58:08Z

Does this look right? (Bear with me, I'm a little new around here).

Never mind, it seems GitHub Actions is already enabled.
@Panquesito7 said that it was enabled. I'm not sure what the issue is.

It does look right. And reviewing the commit history, I do see the corrections made by clang-tidy. Maybe I have to manually invoke clang-format on the code.

kvedala · 2020-08-15T21:59:23Z

Meanwhile, if you can open this PR in GitPod using the link in the description above, when you press save, the appropriate fixes will be applied. you can commit therein; thus simplifying the process

kvedala · 2020-08-16T20:52:01Z

range_queries/heavy_light_decomposition.cpp

-}
-}
+ std::vector<std::list<int>>
+ t_adj; ///> an adjacency list to stores the tree edges


Suggested change

t_adj; ///> an adjacency list to stores the tree edges

t_adj; ///< an adjacency list to stores the tree edges

The comment is incorrect please note that the correct start tag is ///< and not ///>. Also note that this comment must fit on the same line.
Please make the corrections throughout the code.

Looks like clang-format is breaking up the lines 😕.

range_queries/heavy_light_decomposition.cpp

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>

kvedala · 2020-08-17T13:24:29Z

@aneee004 what I recommended was a suggestion and example. By accepting it as is, the points got repeated in the lines below it. please check lines 327 with lines from 323.

aneee004 · 2020-08-17T15:25:05Z

My bad, did not notice it. I'll remove those. Also what about clang-format breaking up the lines?

range_queries/heavy_light_decomposition.cpp

aneee004 added 2 commits August 13, 2020 23:16

Added heavy_light_decomposition.cpp

59e038d

Merge pull request #1 from aneee004/hld

916ebe8

Added heavy_light_decomposition.cpp

Panquesito7 requested changes Aug 13, 2020

View reviewed changes

Panquesito7 added enhancement New feature or request Proper Documentation Required requested to write the documentation properly requested changes changes have been requested labels Aug 13, 2020

aneee004 and others added 7 commits August 14, 2020 00:43

Update range_queries/heavy_light_decomposition.cpp

9ad808d

Co-authored-by: David Leal <halfpacho@gmail.com>

Update range_queries/heavy_light_decomposition.cpp

22a76d2

Co-authored-by: David Leal <halfpacho@gmail.com>

Update range_queries/heavy_light_decomposition.cpp

dfddc81

Co-authored-by: David Leal <halfpacho@gmail.com>

Added function documentation

f4504ca

TODO: Data member documentation.

Update heavy_light_decomposition.cpp

331c522

Update heavy_light_decomposition.cpp

c6ecbb6

Merge pull request #2 from aneee004/function_documentation

4ed05c2

Added function documentation

Panquesito7 requested changes Aug 13, 2020

View reviewed changes

aneee004 added 3 commits August 14, 2020 01:37

Corrected typos, and remove comma

d7ea109

Corrected typos, and removed comma

5a50445

Corrected Typos

6493416

Function documentation

Panquesito7 reviewed Aug 13, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Outdated Show resolved Hide resolved

aneee004 added 2 commits August 14, 2020 02:38

Edited comments

518cbfd

Merge pull request #4 from aneee004/function_documentation

9b0339d

Edited comments

Panquesito7 reviewed Aug 13, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Outdated Show resolved Hide resolved

Update range_queries/heavy_light_decomposition.cpp

edd4b6e

Co-authored-by: David Leal <halfpacho@gmail.com>

Panquesito7 requested changes Aug 13, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Outdated Show resolved Hide resolved

aneee004 and others added 4 commits August 14, 2020 03:01

Added wiki

5800b7c

Create c-cpp.yml

fad3bb5

updating DIRECTORY.md

da4ea73

Merge pull request #5 from aneee004/function_documentation

1904c93

Added wiki

Panquesito7 requested changes Aug 13, 2020

View reviewed changes

.github/workflows/c-cpp.yml Outdated Show resolved Hide resolved

Panquesito7 added approved Approved; waiting for merge and removed awaiting modification Do not merge until modifications are made requested changes changes have been requested labels Aug 15, 2020

Panquesito7 requested a review from kvedala August 15, 2020 02:10

kvedala requested changes Aug 15, 2020

View reviewed changes

aneee004 and others added 2 commits August 15, 2020 20:16

Apply suggestions from code review

2554b72

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>

Added data member documentation

c547a1a

kvedala mentioned this pull request Aug 15, 2020

[BUG] clang-tidy does not format the code #1032

Closed

Formatted Code

d9dd7ce

kvedala reviewed Aug 16, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Outdated Show resolved Hide resolved

Edited data member comments

8e500b8

kvedala reviewed Aug 17, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Outdated Show resolved Hide resolved

Update range_queries/heavy_light_decomposition.cpp

64e8f5a

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>

Update heavy_light_decomposition.cpp

9521353

kvedala reviewed Aug 17, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Show resolved Hide resolved

aneee004 added 2 commits August 18, 2020 00:39

Added testcase verification

e1f8cbc

Update heavy_light_decomposition.cpp

b7c2f0d

kvedala reviewed Aug 18, 2020

View reviewed changes

range_queries/heavy_light_decomposition.cpp Show resolved Hide resolved

Added a new test case

c959c3d

kvedala approved these changes Aug 19, 2020

View reviewed changes

Panquesito7 merged commit 416a3bc into TheAlgorithms:master Aug 19, 2020

	t_adj; ///> an adjacency list to stores the tree edges
	t_adj; ///< an adjacency list to stores the tree edges

Uh oh!

Added heavy_light_decomposition.cpp #1016

Added heavy_light_decomposition.cpp #1016

Uh oh!

Conversation

aneee004 commented Aug 13, 2020 • edited by gitpod-io bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Change

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Panquesito7 left a comment

Choose a reason for hiding this comment

Uh oh!

aneee004 commented Aug 13, 2020

Panquesito7 commented Aug 13, 2020

Uh oh!

aneee004 commented Aug 14, 2020

kvedala left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aneee004 commented Aug 15, 2020

kvedala commented Aug 15, 2020

aneee004 commented Aug 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

kvedala commented Aug 15, 2020

kvedala commented Aug 15, 2020

kvedala Aug 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

aneee004 Aug 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kvedala commented Aug 17, 2020

aneee004 commented Aug 17, 2020

Uh oh!

Uh oh!

Labels

3 participants

aneee004 commented Aug 13, 2020 •

edited by gitpod-io bot

Loading

aneee004 commented Aug 15, 2020 •

edited

Loading

kvedala Aug 16, 2020 •

edited

Loading