Skip to content

Use alias _App for App in type hints under TYPE_CHECKING #6152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use alias _App for App in type hints under TYPE_CHECKING #6152

wants to merge 1 commit into from
+4 −3

Conversation

uriyyo
Copy link

@uriyyo uriyyo commented Oct 2, 2025

Hi,

First of all, thanks for such a great library, really enjoy using it 🙌

I have found small issue. App imported in __init__ of textual, but it imported only in if TYPE_CHECKING block, because of that mypy and other tools think that from textual import App is valid code.

from textual import App
$ mypy example.py Success: no issues found in 1 source file

This PR will import App as _App, so IDEs and other tools will show an error for:

from textual import App

Please review the following checklist.

  • Docstrings on all new or modified functions / classes
  • Updated documentation
  • Updated CHANGELOG.md (where appropriate)
@uriyyo uriyyo force-pushed the bugfix/app-import branch from d473627 to 49fc78d Compare October 5, 2025 13:53
@uriyyo uriyyo mentioned this pull request Oct 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@uriyyo