build!: update supported Python versions #6121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Tests failed with Python 3.9 with I've not dived into this yet, but earlier versions of pytest-asyncio might have been hiding some test issues: pytest-dev/pytest-asyncio#1039 |
After upgrading `pytest-asyncio` to the latest version, lots of tests started failing in CI only on Python 3.9: `RuntimeError: There is no current event loop in thread 'MainThread'` Apparently these tests may have only been passing previously due to issues in earlier versions of `pytest-asyncio`. Changing these tests to async seems to fix the failures on Python 3.9. Related issue: pytest-dev/pytest-asyncio#1039
| Unfortunately I've discovered that the Textual devtools currently doesn't support Python 3.14: |
allow-prereleases is no longer needed for Python 3.14.
| Hi @TomJGooding Curious why you made the test async. What was that solving? |
See comments in 7a9d32f |
Closed
| Thanks, Tom. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Python 3.14 should be released in just a few weeks, which means Python 3.8 has been end-of-life for almost a year.
This drops support for Python 3.8 and adds testing in CI for Python 3.14.
Please review the following checklist.