Textual run not respecting interpreter choice #47
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
when trying to run a Textual app without activating the envirionment (out of laziness or in scripts) using e.g.
it will look up "python" in
$PATH
instead of using the one in.venv/
. This results in it trying to run the app with the system interpreter and thus not being able to import Textual.the reason for this is this line of code.
textual-dev/src/textual_dev/tools/run.py
Line 108 in 6485ab6
Apparently (I didn't know this either) the executable from args is used, not the one given to
os.execvpe()
, at least on linux, and since that is just "python" it is looked up in$PATH
.Also, there is no need to use
execvpe()
instead ofexecve()
becausesys.executable
is always absolute