Show traceback on import errors #33
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Getting an import error while trying to
from foo import bar
does not mean specifically thatbar
could not be imported fromfoo
.It might mean a bunch of things:
foo
wasn't foundbar
wasn't found infoo
(the assumed case and probably the reason that the traceback is hidden as of now)foo
's code raised an unrelated import errorIn the last case, we never get to know what inner import causes the import failure.
Thus, let's always show the import error traceback.
I didn't make an additional
--tb
/--show-traceback
switch (similar to the one mypy has) because I see it as an overkill for a package that ends with-dev
.In this PR I also cleaned some leftovers that probably should instead be picked up by linters in CI; a good reason for another PR.