Fix textual CLI not working, drop Python 3.7. #28
+602 −996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… 3.8+. Also fixes the missing importlib_metadata backport dependency being missing.
rodrigogiraoserrao approved these changes Dec 19, 2023
| Can you bump the version in this PR and I'll do a release. |
| @willmcgugan Bumped to 1.3.0 |
| Ta |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
textualCLI tool didn't work becauseimportlib_metadatawasn't in the dependencies.It must have worked coincidentally before, since that was specified in Textual's own dependencies until recently.
Drop Python 3.7 support, update to use importlib.metadata module from 3.8+.