Extend the search for a terminal name and version #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Testing out Contour, it does things a little differently again. This will take this into account and will report Contour and its version.
I did this a while ago, and it seems to be in a branch on two machines, but not in main and not actually in the repo, for some odd reason. Either way, this seems worth having...
| term_program = f"{term_program} ({term_version})" | ||
| | ||
| return "*Unknown*" if term_program is None else term_program | ||
| # Seems we can't work this out. |
There was a problem hiding this comment.
I see these changes in this commit but I don’t see them in the final “changes” of the PR. What am I missing?
There was a problem hiding this comment.
The fact that I was working on a fork that I forgot to sync, was confused as to why the screen detection wasn't in the code, added it to this, then realised what was going on, did a sync, a merge, and then it had the effect of nullifying that change.
darrenburns approved these changes Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Testing out Contour, it does things a little differently again. This will take this into account and will report Contour and its version.