This repository was archived by the owner on Mar 27, 2020. It is now read-only.
Construct email. Fixes #7. #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JohannesEbke force-pushed the construct-email branch from 06bba04 to c3b4622 Compare 
Current coverage is 81.06%@@ master #19 diff @@ ========================================== Files 7 8 +1 Lines 354 359 +5 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 280 291 +11 - Misses 43 68 +25 + Partials 31 0 -31
|
gpg/gpg_test.go Outdated
| | ||
| func TestGPGEncryptMessage(t *testing.T) { | ||
| gpg := setupGPG(t) | ||
| assert.NotNil(t, gpg) |
Collaborator
There was a problem hiding this comment.
This check is not really necessary, since that case would(should) have been caught in setupGPG.
JohannesEbke force-pushed the construct-email branch from b4fdbd5 to a4211d7 Compare | const prefix = "../test/keys/test-gpg-validation@server.local (0x87144E5E) " | ||
| const asciiKeyFilePublic = prefix + "pub.asc" | ||
| const asciiKeyFilePrivate = prefix + "sec.asc" | ||
| const passphrase = "validation" |
Collaborator
There was a problem hiding this comment.
Maybe we should move that into a shared package like we did with test/utils.
JohannesEbke force-pushed the construct-email branch from 5b3dd1e to 05b5ad5 Compare Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.