Fix shader for old IPhone #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Similar issues may also be found in other SDF components. The changes made should work more stably on older versions of Metal. |
| Thanks for the pull request! I tested it on my development machine, and it seems much more stable. I don't have an iOS device to test on, but I'm confident in your changes and plan to merge this soon. I'll be making a small adjustment after the merge to fix an issue with the SDF texture rotation. This involves swapping the y-axis values for |
TLabAltoh added a commit that referenced this pull request Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Discovered a problem on older iPhones (iPhone SE A1723, iOS 15.8.4) some SDFQuad is rendered in black instead of the color used in the material. The suggested changes based on initial testing should resolve this issue.