Skip to content

Conversation

@AAAYaKo
Copy link
Collaborator

@AAAYaKo AAAYaKo commented Aug 14, 2024

Added settings window with default parameters for SDFUI and default antialiasing algorithm.

@AAAYaKo
Copy link
Collaborator Author

AAAYaKo commented Aug 14, 2024

image

@TLabAltoh TLabAltoh merged commit 26f171a into TLabAltoh:master Aug 14, 2024
@TLabAltoh
Copy link
Owner

I changed only the menu item path from TLab/Settings to TLab/UI/SDF/Settings to avoid conflicts with the menu item path of other modules.

//[MenuItem("TLab/Settings")] [MenuItem("TLab/UI/SDF/Settings")] public static void Create() { SDFUISettingsEditor wnd = GetWindow<SDFUISettingsEditor>(true, "SDFUISettings"); }
TLabAltoh added a commit that referenced this pull request Aug 14, 2024
@AAAYaKo
Copy link
Collaborator Author

AAAYaKo commented Aug 14, 2024

Ideally, it would be possible to generate resources in the Assets folder as in the TMP package via a dialog window, but for now the files are constantly being created. I plan to rework this later.

TLabAltoh added a commit that referenced this pull request Aug 14, 2024
- remove antialiasing artifact on outline width 0 - change antialiasing direction from outside to both side (in/out) - added keyword to hide shader's shadow part to optimize performance - changed shader to multipass to properly blend with shadows and shapes (this change related antialiasing artifact problem) - commonized shader's some process part to include file
@TLabAltoh
Copy link
Owner

TLabAltoh commented Aug 14, 2024

I’ve invited you to be a collaborator on this repository. You should be able to see the notification on GitHub’s notification page.

If you are a collaborator. You can push your update directly to this repository.

For major updates like adding new features, it would be great if you could use pull requests, or create new branch in this repositry and notice it at issues or discussions. That way, I can review it once (in which case I will merge your branch into the master if it seems no problem).

However, for small fixes or updates that related to the above, feel free to push update to this repositry's master directly without notification (that way, you don't have to make another pull request, which is more convenient). But if you made small update and it seems need to make notification, feel free to make notification at related issue or discussion or pull request's thread.

If you made merge request via pull request, maybe it takes an effort for you to push directly of small update related to it to master branch after merging it. So in this case, it is no problem to make another pull request for small update related to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants