[docs] Code snippet example about how to use Select2 with this bundle #42
Conversation
| Do you refer to any known issue or PR with these changes? |
| If you're using [Select2](https://select2.org/) that is instantiated on the page load, you may need to wrap it in a Stimulus controller to make it work when new fields dynamically pop up into your HTML DOM. | ||
| Example: [Symfony UX Turbo](https://symfony.com/bundles/ux-turbo/current/index.html#decomposing-complex-pages-with-turbo-frames) + [Custom stimulus controller](https://stimulus.hotwired.dev/reference/controllers) | ||
| | ||
| **_select2_controller.js_** |
There was a problem hiding this comment.
No need in this as the file name along with the path is specified in the code block itself
| this.select.select2('destroy'); | ||
| } | ||
| | ||
| bindOnSelect2Event(select2) { |
There was a problem hiding this comment.
I would move this method after initBaseSelector() for better readability
| allowClear: {type: Boolean, default: false}, | ||
| placeholder: {type: String, default: null}, | ||
| closeOnSelect: {type: Boolean, default: true} |
There was a problem hiding this comment.
Maybe group bool types together? Like:
| allowClear: {type: Boolean, default: false}, | |
| placeholder: {type: String, default: null}, | |
| closeOnSelect: {type: Boolean, default: true} | |
| placeholder: {type: String, default: null}, | |
| allowClear: {type: Boolean, default: false}, | |
| closeOnSelect: {type: Boolean, default: true}, |
| Hi @KamikX! Thanks for the contribution! After talking it over, we're not going to merge this as we feel it falls too far outside of the scope. However, this PR is now findable and this would be a great addition to something like StackOverflow. Cheers! |
PR refer to this issue and your suggestio. |
| Thanks for sharing the cross-link! Now it will be easier to find your code snippet for others on GitHub 👍 |
bocharsky-bw changed the title 3 participants
add Knowledge base - usage with third party libraries section with Select2 example