Skip to content

Conversation

@yasar-sumologic
Copy link
Contributor

…Tel app doc

Purpose of this pull request

Changes to haproxy-otel app doc after changes in it to add metric collection and metric-based dashboards

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

@yasar-sumologic yasar-sumologic added the do-not-merge Pull requests that should not be merged label Jul 2, 2024
@cla-bot
Copy link

cla-bot bot commented Jul 2, 2024

Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we'll add you to our approved list of contributors.

@jpipkin1 jpipkin1 mentioned this pull request Jul 2, 2024
4 tasks
Copy link
Collaborator

@kimsauce kimsauce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes!

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Jul 2, 2024
@yasar-sumologic yasar-sumologic removed the do-not-merge Pull requests that should not be merged label Jul 9, 2024
@sumoanema sumoanema requested a review from kimsauce July 9, 2024 04:23
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes

@sumoanema sumoanema requested a review from JV0812 July 11, 2024 06:25
Copy link
Collaborator

@JV0812 JV0812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sumoanema
Copy link
Collaborator

@kimsauce - Could you please have look at this PR.

@kimsauce
Copy link
Collaborator

Could you please have look at this PR.

@sumoanema all set! Looks good.

@sumoanema sumoanema added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit 98b0c3a Jul 12, 2024
@sumoanema sumoanema deleted the haproxyOtel branch July 12, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed Contributor approved, listed in .clabot file

6 participants