- Notifications
You must be signed in to change notification settings - Fork 227
Add metrics collection and metrics-based dashboards info to HAProxy Otel app #4265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Thank you for your contribution! As this is an open source project, we require contributors to sign our Contributor License Agreement and do not have yours on file. To proceed with your PR, please sign your name here and we'll add you to our approved list of contributors. |
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
kimsauce left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor changes!
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
docs/integrations/web-servers/opentelemetry/haproxy-opentelemetry.md Outdated Show resolved Hide resolved
JV0812 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fixes
JV0812 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| @kimsauce - Could you please have look at this PR. |
@sumoanema all set! Looks good. |
…Tel app doc
Purpose of this pull request
Changes to haproxy-otel app doc after changes in it to add metric collection and metric-based dashboards
Select the type of change
Ticket (if applicable)