Skip to content

feat: remove babel jsesc workaround #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2024
Merged

feat: remove babel jsesc workaround #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033f163
feat: remove babel jsesc workaround
SukkaW Oct 11, 2024
3182090
test: update snapshot
SukkaW Oct 11, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/react-compiler-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ export default async function reactCompilerLoader(this: webpack.LoaderContext<Re
sourceFileName: this.resourcePath,
filename: this.resourcePath,
cloneInputAst: false,
generatorOpts: {
...babelTransFormOpt?.generatorOpts,
// https://github.com/facebook/react/issues/29120
// TODO: remove once React Compiler has provided their workaround
jsescOption: {
minimal: true,
...babelTransFormOpt?.generatorOpts?.jsescOption
}
},
// user configured babel option
...babelTransFormOpt,
// override babel plugins
Expand Down
4 changes: 2 additions & 2 deletions test/__snapshots__/index.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function Comp() {
let t0;
if ($[0] === Symbol.for(\\"react.memo_cache_sentinel\\")) {
t0 = /*#__PURE__*/ _jsx(\\"div\\", {
\\"aria-label\\": \\"我能吞下玻璃而不伤身体\\",
\\"aria-label\\": \\"\\\\u6211\\\\u80FD\\\\u541E\\\\u4E0B\\\\u73BB\\\\u7483\\\\u800C\\\\u4E0D\\\\u4F24\\\\u8EAB\\\\u4F53\\",
children: \\"我能吞下玻璃而不伤身体\\"
});
$[0] = t0;
Expand Down Expand Up @@ -165,7 +165,7 @@ export default function Comp() {
let t0;
if ($[0] === Symbol.for(\\"react.memo_cache_sentinel\\")) {
t0 = /*#__PURE__*/ _jsx(\\"div\\", {
\\"aria-label\\": \\"我能吞下玻璃而不伤身体\\",
\\"aria-label\\": \\"\\\\u6211\\\\u80FD\\\\u541E\\\\u4E0B\\\\u73BB\\\\u7483\\\\u800C\\\\u4E0D\\\\u4F24\\\\u8EAB\\\\u4F53\\",
children: \\"我能吞下玻璃而不伤身体\\"
});
$[0] = t0;
Expand Down