Fix CI/CD by correcting the version.h path in build_inc.py #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Co-authored-by: Stateford <15315637+Stateford@users.noreply.github.com>
Co-authored-by: Stateford <15315637+Stateford@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix the broken CI/CD Fix CI/CD by correcting the version.h path in build_inc.py May 21, 2025
Stateford reviewed May 21, 2025
| raise BuildError("Something went wrong with build") | ||
| | ||
| write_header( | ||
| os.path.abspath("./Display-Lock/resources/version.h"), |
Author
There was a problem hiding this comment.
I've enhanced the script to be more robust when finding the version.h file. The updated implementation in 46b4a16 will now:
- Try multiple possible file paths for the version.h file
- Add detailed logs about where it's searching and what it finds
- Work correctly regardless of the working directory it's run from
- Provide better error handling with detailed error messages
This should address the CI/CD pipeline issue by making the script more resilient to environment differences.
Co-authored-by: Stateford <15315637+Stateford@users.noreply.github.com>
Stateford reviewed May 21, 2025
scripts/build_inc.py Outdated
| project_root = os.path.dirname(script_dir) # Assuming script is in a scripts/ directory at project root | ||
| | ||
| # Try different possible locations for the version.h file | ||
| possible_paths = [ |
Author
There was a problem hiding this comment.
I've simplified the implementation with a more elegant solution in a0d1af2. The script now uses a direct, concise approach to locate the version.h file without excessive debugging or complex path detection logic.
Co-authored-by: Stateford <15315637+Stateford@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue
The CI/CD pipeline was failing because the
build_inc.pyscript couldn't find the correct path to theversion.hfile during the build process.Changes
This PR makes a single targeted change to fix the CI/CD pipeline:
build_inc.pyfrom./Display-Lock/resources/version.hto./src/resources/version.hto match the actual project structureTesting
version.hfile with different configuration parametersThe fix is minimal and focused only on correcting the file path, ensuring the version information is correctly updated during the build process.
Fixes #127.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.