[pull] master from espressif:master #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
Added initialization time for UART, etc. Default value is 0.
Add function definition and SET_SETUP_WAIT_TICH function
typo
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This PR will allow the user to modify the MIDI USB Device Name (device descriptor). Fomer API continues to be valid and the default device name is "TinyUSB MIDI". The user can change the device name by passing a string to the constructor, declaring it like this `USBMIDI myMIDI("MyDeviceName"); The problem affects more often SoC that supports REF_TICK UART Clock source (ESP32 and ESP32-S2). The implementation has an issue retated to when the user doesn't set any specific UART source clock and the UART changes its baudrate from lower than 250,000 to higher (ESP32/ESP32-S2). The bug is about not changing the clock source to something faster (APB) in order to get correct clock resolution in order to reach closer enough to the new baudrate selection. The new behaviour (which was working before) is that is the application doesn't set any specific UART clock rate, it shall follow a rule: ESP32/ESP32-S2 will use REF_TICK whenever baudrate is lower than 250,000. Other SoC will use XTAL. ESP32/ESP32-S2 will change UART Clock Source to APB when baudrate is higher than 250,000 for a better final result. If the user application explicitaly changes the UART Clock Source using `setClockSource()`, this new clock source will be used always, independently from the target SoC and selected baudrate (overriding the rule above).
Adds a new function `rmtWriteLoopingCount()` to send a specific number of times, repeating the same RMT Symbols.
Adds: bool rmtWriteLoopingCount(int pin, rmt_data_t *data, size_t num_rmt_symbols, uint32_t loop_count) It will send a pattern defined by `*data` RMT Symbols for `loop_count` times (repeated). This is different from `rmtWriteLooping()`, which will repeat it for ever (endless looping).
Updated MIDI device initialization to use default constructor.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
feat(core): Add wait time before setup
feat(usb): allow the MIDI constructor to define a device name
fix(uart): always applies the user selected UART Clock Source
feat(rmt): adds new function to send specific number of loops
…eaders feat(HTTPClient): add support for collecting all HTTP headers
ci(pre-commit): Comment when fixes are needed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )