cd: use correct login action for acr

[ddlees]

Summary by CodeRabbit

• Chores
  • Updated the publishing workflow to use a different login action for container registry authentication. No changes to user-facing features.

[coderabbitai]

Walkthrough

The GitHub Actions workflow for publishing containers was updated by replacing the Azure-specific Docker login action with the generic Docker login action, and by updating the relevant input parameter to match the new action's requirements. No changes were made to public or exported code entities.

Changes

Cohort / File(s)	Change Summary
Workflow Action Update .github/workflows/publish.yml	Replaced azure/docker-login@v1 with docker/login-action@... in the containerize job; updated input from login-server to registry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• cd: publish stable images to azure container registry #145: Adds a login step using azure/docker-login@v1 in the same workflow file, indicating related changes around Azure Container Registry authentication.

Suggested reviewers

• Holocraft

Poem

A workflow hops with nimble feet,
From Azure's login, skips a beat.
Now Docker's action takes the stage,
With secrets safe, it turns the page.
The registry waits, the image flows—
A rabbit cheers as progress grows! 🐇

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-login-action

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/publish.yml (2)

166-171: Minor hygiene: consider logging out after pushes

Ephemeral runners reduce risk, but adding docker/logout-action for both registries tightens supply-chain hygiene.

Example:

- name: Logout from GHCR uses: docker/logout-action@v3 with: registry: ghcr.io - name: Logout from ACR uses: docker/logout-action@v3 with: registry: ${{ secrets.ACR_AZUREHOUND_REGISTRY_URL }}

---

166-171: Optional: ensure the pinned commit is up-to-date

You’re pinning docker/login-action to a commit (good for integrity). Consider tracking updates (e.g., with Dependabot) to pick up security and bug fixes on that action SHA.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8f3d524 and 2fc0d7c.

📒 Files selected for processing (1)

• .github/workflows/publish.yml (1 hunks)

🔇 Additional comments (2)

.github/workflows/publish.yml (2)

166-171: Switch to docker/login-action and input rename look correct

Using docker/login-action with the registry input is appropriate for ACR. Credentials mapping (client ID/secret) also looks correct.

---

168-168: Verify ACR registry secret format (must be hostname only, no scheme)

Ensure ACR_AZUREHOUND_REGISTRY_URL resolves to something like myregistry.azurecr.io (no https://, no trailing slash). If it includes a scheme or path, both login and image tagging will fail.