EWiseAdd Fusion #45
Closed
EWiseAdd Fusion #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
artemgl reviewed Sep 19, 2022
| isUniqueBitmap.[i] <- 1 | ||
| | ||
| if i < indicesBufferLength - 1 && indicesBuffer.[i] = indicesBuffer.[i + 1] then | ||
| isUniqueBitmap.[i] <- 0 |
There was a problem hiding this comment.
Does it cause double access to global memory?
| let gid = range.GlobalID0 | ||
| | ||
| if gid < indicesBufferLength then | ||
| newIndecies.[gid] <- rowsBuffer.[gid] * colsCount + colsBuffer.[gid] |
There was a problem hiding this comment.
This mapping is not injective. Although, this can cause improper behavior in extremely rare cases
gsvgit reviewed Sep 22, 2022
| (columns: int []) | ||
| (values: 'a []) | ||
| : GraphblasEvaluation<Matrix<'a>> = | ||
| : GraphblasEvaluation<Mat<'a>> = |
There was a problem hiding this comment.
What is Mat? Why not Matrix? If we really need new name for matrix, Mtx looks better.
| let! lowerTriangular = | ||
| matrix | ||
| |> Matrix.select (UnaryOp <@ fun (i, j, _) -> i <= j @>) | ||
| let sandia (matrix: Mat<bool>) = graphblas { |
There was a problem hiding this comment.
Does it work? What about performance?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed Changes
EWiseAddBatchedoperation, which allows you to simultaneously add multiple COO matricesEWiseAddBatched.fs,MatrixEWiseAddBatchedTests.fs,BenchmarksEWiseAddBatched.fsfilesTypes of changes
What types of changes does your code introduce to GraphBLAS-sharp?
Checklist