GraphBLAS object prototypes #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gsvgit reviewed Nov 10, 2020
| let inline (!>) (x: ^a) : ^b = (^a : (static member op_Implicit : ^a -> ^b) x) | ||
| | ||
| let private provider = | ||
| try ComputeProvider.Create("INTEL*", DeviceType.Cpu) |
There was a problem hiding this comment.
Can we provide a platform name and device type as parameters?
| @@ -0,0 +1,16 @@ | |||
| namespace GraphBLAS.FSharp | |||
| | |||
| type Semiring<'a> = { | |||
There was a problem hiding this comment.
Why it is not a struct with two constructors?
| @@ -0,0 +1,16 @@ | |||
| namespace GraphBLAS.FSharp | |||
| | |||
| type Semiring<'a> = { | |||
There was a problem hiding this comment.
Read carefully these three definitions of semiring:
- https://ru.wikipedia.org/wiki/%D0%9F%D0%BE%D0%BB%D1%83%D0%BA%D0%BE%D0%BB%D1%8C%D1%86%D0%BE
- https://en.wikipedia.org/wiki/Semiring
- https://people.eecs.berkeley.edu/~aydin/GraphBLAS_API_C_v13.pdf (Section 3.3 Semitings)
They are different. We should discuss, which one we should use.
gsvgit pushed a commit that referenced this pull request Feb 19, 2021
Matrices loading is optimized.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.