fix for creating new Sortable with SortableJS 1.5.1 #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
SortableJS 1.5.1 has a create() function for creating a new Sortable object. It was causing some TypeErrors as new Sortable() was not a constructor anymore. This changes the implementation to create a new Sortable object using the create function instead. Also, updates de README file for mapping correctly the minify version of sortablejs in SystemJS configuration. Fixes SortableJS#42
Author
| I just found out I'm having some issues with SortablejsOptions as well. I'm going to investigate further on this. |
Member
| Thanks for the contribution 👍 |
Member
| @FlorKaucic should be fixed in 2.0.3 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
SortableJS 1.5.1 has a create() function for creating a new Sortable object. It was causing some TypeErrors as new Sortable() was not a constructor anymore.
This changes the implementation to create a new Sortable object using the create function instead.
Also, updates de README file for mapping correctly the minify version of sortablejs in SystemJS configuration.
Fixes #42