package updates and build fix #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
| Hi @lbertenasco thank you for pull request 👍 . I am thinking to merge it next week to release it under 2.0.0 (I also want to make some breaking changes). Just FYI |
Member
| do you think does is it supposed to fix #34 as well? |
Contributor Author
| Hi @smnbbr, thanks. About the AoT Rollup issue I'm not sure, I would need to check with a sample repo. |
Member
| hi @lbertenasco thank you for contribution. I moved sortablejs to the peerDependencies, so you can try it now with your projects with npm install --save sortablejs && npm install --save angular-sortablejs@2.0.0-0Please let me know if this works so we can make a stable 2.0.0 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.