Use an isb as a pause instruction on arm64 platforms. #441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In other projects spinlock implementations and focused testing we've found that an isb pauses execution for about the same time as an x86 pause instruction. The yield instruction behaves as a nop and thus doesn't pause the CPU at all which leads to both more contention on the lock that is being spun on and also a much lower spin-time vs. x86 for the same spin loop constants. Given this is userspace code, using a wfe isn't advisable.
| It would be great if someone could test or prove out this is helpful with the contention levels expected in KeyDB usage. I'm proposing this change based on what we've seen in other applications that spin. |
| Thanks! Is ISB available on all aarch64 architectures or do we need a more specific ifdef? |
| it is available starting in armv8.0 so all. It's an instruction synch barrier, so it stops the front end until the backend empties but it's the most reliable instruction we've found until one that is available in Arm v8.6 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In other projects spinlock implementations and focused testing we've
found that an isb pauses execution for about the same time as an x86
pause instruction. The yield instruction behaves as a nop and thus
doesn't pause the CPU at all which leads to both more contention on the
lock that is being spun on and also a much lower spin-time vs. x86 for
the same spin loop constants. Given this is userspace code, using a wfe
isn't advisable.