#1184 don not uppercase environment variables #1224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This has nothing to do with #1184 but I didn't kow that string.replace did a replace all so I used the regex version and that is stupid so I set those to replace. As I was doing this and I'll need to test this toroughly I think this is the right moment to check these in
Basically all casing problems I added uppercase variants pointing to lowercase variants for the stuff defined in plugin.xml
This has nothing to do with #1184 but I didn't kow that string.replace did a replace all so I used the regex version and that is stupid so I set those to replace. As I was doing this and I'll need to test this toroughly I think this is the right moment to check these in
Basically all casing problems I added uppercase variants pointing to lowercase variants for the stuff defined in plugin.xml
https://github.com/Sloeber/arduino-eclipse-plugin.git into #1184_don_not_uppercase_environment_variables Conflicts: io.sloeber.core/src/io/sloeber/core/Messages.java io.sloeber.core/src/io/sloeber/core/api/BoardDescriptor.java io.sloeber.core/src/io/sloeber/core/api/PackageManager.java io.sloeber.core/src/io/sloeber/core/common/Common.java io.sloeber.core/src/io/sloeber/core/common/ConfigurationPreferences.java io.sloeber.core/src/io/sloeber/core/common/Const.java io.sloeber.core/src/io/sloeber/core/messages.properties io.sloeber.core/src/io/sloeber/core/tools/Helpers.java io.sloeber.ui/src/io/sloeber/ui/preferences/PreferencePage.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.