Centralize workarounds #1173
Merged
Centralize workarounds #1173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This fix creates and works with a sloeber variant of boards.txt and platfrom.txt. This way the original files are not touched. This works with previously installed released versions. Nightly gives issues with some boards due to double workarounds. Removing and installing again does the trick The first line in the sloeber variants is used to identify the "workaround version" to enable updates on the fly NOTE: this change also copies the package json file to the platform but is not yet using it. Still need to think how to get this to work safely
Conflicts: io.sloeber.core/src/io/sloeber/core/managers/InternalPackageManager.java io.sloeber.core/src/io/sloeber/core/managers/Package.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Test are fine now on linux and windows