Skip to content

[Feature] Improve type safety by using react-router generated route specific types #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Feature] Improve type safety by using react-router generated route specific types #65

wants to merge 1 commit into from

Conversation

k-melnychuk
Copy link
Contributor

This PR improves type safety by replacing generic LoaderFunctionArgs (and similar types) with route-specific types generated by React Router.

Why

  • More accurate type inference for loaders, actions, and components
  • Safer and clearer alignment with route definitions
  • Better autocompletion and DX

Checklist

  • I have made changes to the README.md file and other related documentation, if applicable
  • I have added an entry to CHANGELOG.md
  • I'm aware I need to create a new release when this PR is merged
@k-melnychuk k-melnychuk requested a review from a team as a code owner September 24, 2025 02:09
@k-melnychuk
Copy link
Contributor Author

I have signed the CLA!
@k-melnychuk k-melnychuk mentioned this pull request Sep 25, 2025
Closed
3 tasks
@k-melnychuk
Copy link
Contributor Author

@byrichardpowell @lizkenyon can this PR be looked at and merged in please? 😊

it’ll be nice to merge this in so that the auth middleware can get moving as well 🥹
@k-melnychuk
Copy link
Contributor Author

Hey @byrichardpowell 👋
I appreciate your reply about the auth middleware! Can this PR still be merged in, though?
Unless there's a reason why we shouldn't be using RR-generated Route types?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@k-melnychuk