Fixing corrupting of FLAC files where there is no padding or no metada blocks #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hm, yeah I don't think any of the FLAC tests have a file with just a single metadata block. I'll test it out in a couple days when I have time. Thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is the companion PR to #549
I'm not feeling entirely confident that I'm following all the various accouting being done here to keep track of everything.
I think there's still an outsstanding bug where we're not setting the last flag correctly if we have no padding and are removing all picture blocks.
However, if you review it and you think I have it correct, this should fix the FLAC corruption problems I've been seeing.