WAV: Constrain writer to stream length not file length #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Serial-ATA force-pushed the riff-size-contraint branch from 19a236e to d573055 Compare 
Previously, tags were simply written to the end of the file, but this would break files that have junk data appended. This allows for files with appended junk data that falls outside of the stream length. This can be caused by buggy software misusing padding.
Serial-ATA force-pushed the riff-size-contraint branch from d573055 to ce46b04 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously, tags were simply written to the end of the file, but this would break files that have junk data appended.
This allows for files with appended junk data that falls outside of the stream length. This can be caused by buggy software misusing padding.