id3v2: Distinguish COMM frames by content descriptor #121
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Plain comments are supposed to have an empty description aka content descriptor. Only those must appear as
ItemKey::Comment, otherwise this would cause confusion and inconsistencies during the read/write round trip.TODO
ItemKey::Comment?Test that unsupported frames with a non-empty content descriptor are preserved during a read/write round trip.Out of scope, nothing to do here. Conversions fromID3v2TagtoTagare expected to be lossy and applications are responsible for preserving unmapped MP3 metadata frames. All operations directly onID3v2Tagare unaffected by the changes.