Skip to content

chore(FormTextArea): use React.forwardRef() #4405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2022
Merged

chore(FormTextArea): use React.forwardRef() #4405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/collections/Form/FormTextArea.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,15 @@ import FormField from './FormField'
* @see Form
* @see TextArea
*/
function FormTextArea(props) {
const FormTextArea = React.forwardRef(function (props, ref) {
const { control } = props
const rest = getUnhandledProps(FormTextArea, props)
const ElementType = getElementType(FormTextArea, props)

return <ElementType {...rest} control={control} />
}
return <ElementType {...rest} control={control} ref={ref} />
})

FormTextArea.displayName = 'FormTextArea'
FormTextArea.propTypes = {
/** An element type to render as (string or function). */
as: PropTypes.elementType,
Expand Down
1 change: 1 addition & 0 deletions test/specs/collections/Form/FormTextArea-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import * as common from 'test/specs/commonTests'

describe('FormTextArea', () => {
common.isConformant(FormTextArea)
common.forwardsRef(FormTextArea, { tagName: 'textarea' })
common.labelImplementsHtmlForProp(FormTextArea)

it('renders a FormField with a TextArea control', () => {
Expand Down