Skip to content

[dotnet] [bidi] Modules as extensions #16392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 7, 2025
Merged

[dotnet] [bidi] Modules as extensions #16392

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f4edf7a
Dummy
nvborisenko Oct 6, 2025
1307265
Merge branch 'trunk' into bidi-module-init
RenderMichael Oct 6, 2025
8e50068
Refactor so each module controls its own JSON serialization
RenderMichael Oct 6, 2025
283376e
Remove commented code
RenderMichael Oct 6, 2025
4a9fa75
Tighten flow for JSON configuration
RenderMichael Oct 7, 2025
1fb3389
Hold json context per module
nvborisenko Oct 7, 2025
3b2f9f4
Introduce AsModule method in BiDi
nvborisenko Oct 7, 2025
a832596
Revert to one big json context
nvborisenko Oct 7, 2025
d5d6877
Move ownership of json options to bidi
nvborisenko Oct 7, 2025
c447d75
BiDi shared json context for built-in modules
nvborisenko Oct 7, 2025
5db0fd0
Don't allow to modify json context from derived type
nvborisenko Oct 7, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't allow to modify json context from derived type
  • Loading branch information
@nvborisenko
nvborisenko committed Oct 7, 2025
commit 5db0fd00bff59e7fb65a50da9db5432c3bb2683e
2 changes: 1 addition & 1 deletion dotnet/src/webdriver/BiDi/Module.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public abstract class Module
{
protected Broker Broker { get; private set; }

internal BiDiJsonSerializerContext JsonContext { get; set; }
internal BiDiJsonSerializerContext JsonContext { get; private set; }

protected virtual void Initialize(JsonSerializerOptions options) { }

Expand Down