Skip to content

Conversation

@rpallavisharma
Copy link
Member

@rpallavisharma rpallavisharma commented Jul 30, 2025

User description

Removed line Javascript API document generation is broken. i saw the github issue states its fixed and checked the api link.

🔗 Related Issues

💥 What does this PR do?

Removed the line that Javascript API doc generation is broken, the github issue listed shows its fixed and the link is fixed.

🔧 Implementation Notes

💡 Additional Considerations

🔄 Types of changes

  • Cleanup (formatting, renaming)
  • Bug fix (backwards compatible)
  • New feature (non-breaking change which adds functionality and tests!)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR Type

Documentation


Description

  • Remove outdated note about broken JavaScript API documentation

File Walkthrough

Relevant files
Documentation
README.md
Remove broken JavaScript docs note                                             

README.md

  • Removed outdated note stating JavaScript API documentation generation
    is broken
+0/-2     

Removed line Javascript API document generation is broken. i saw the github issue states its fixed and checked the api link.
@rpallavisharma rpallavisharma self-assigned this Jul 30, 2025
@qodo-merge-pro
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ❌

5678 - Not compliant

Non-compliant requirements:

• Fix ConnectFailure (Connection refused) error when instantiating ChromeDriver
• Error occurs for all instances after the first ChromeDriver instantiation
• Issue affects Ubuntu 16.04.4, Chrome 65.0.3325.181, ChromeDriver 2.35, Selenium 3.9.0

1234 - Not compliant

Non-compliant requirements:

• Fix JavaScript execution in link's href attribute when using click() method
• Issue affects Firefox 42.0 with Selenium 2.48.0 and 2.48.2
• JavaScript should trigger properly on click events

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected
@qodo-merge-pro
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@rpallavisharma
Copy link
Member Author

Copy link
Member

@cgoldberg cgoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cgoldberg cgoldberg merged commit 7407515 into SeleniumHQ:trunk Jul 30, 2025
11 checks passed
@rpallavisharma
Copy link
Member Author

thank you @cgoldberg

@rpallavisharma rpallavisharma deleted the patch-1 branch September 8, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants