Skip to content

Conversation

@cgoldberg
Copy link
Member

@cgoldberg cgoldberg commented May 14, 2025

User description

🔗 Related Issues

Fixes #15734
Fixes #15732

💥 What does this PR do?

This PR adds an id property to the selenium.webdriver.remote.shadowroot.ShadowRoot class.

This attribute was missing and causing errors when trying to access shadow_root

🔄 Types of changes

  • Bug fix (backwards compatible)

PR Type

Bug fix


Description

  • Add missing id property to ShadowRoot class

  • Fix errors when accessing shadow_root.id


Changes walkthrough 📝

Relevant files
Bug fix
shadowroot.py
Add `id` property to ShadowRoot class                                       

py/selenium/webdriver/remote/shadowroot.py

  • Added an id property to the ShadowRoot class
  • Ensures access to the shadow root's internal id
  • Addresses errors when accessing shadow_root.id
  • +4/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @selenium-ci selenium-ci added the C-py Python Bindings label May 14, 2025
    @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @qodo-merge-pro
    Copy link
    Contributor

    qodo-merge-pro bot commented May 14, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    2 participants