Skip to content

Conversation

@nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Mar 29, 2025

User description

Motivation and Context

CanGetClientWindows is now supported by chromium.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Tests


Description

  • Unignored the CanGetClientWindows test for Chromium.

  • Removed browser ignore annotations for Chrome and Edge.

  • Ensured compatibility of the test with Chromium's BiDi support.


Changes walkthrough 📝

Relevant files
Tests
BrowserTest.cs
Unignored `CanGetClientWindows` test for Chromium               

dotnet/test/common/BiDi/Browser/BrowserTest.cs

  • Removed IgnoreBrowser annotations for Chrome and Edge.
  • Enabled the CanGetClientWindows test for Chromium.
  • +0/-2     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @qodo-merge-pro
    Copy link
    Contributor

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 PR contains tests
    🔒 No security concerns identified
    ⚡ No major issues detected
    @qodo-merge-pro
    Copy link
    Contributor

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @nvborisenko
    Copy link
    Member Author

    CI is failing unrelated to this PR, just merging.

    @nvborisenko nvborisenko merged commit 1318f59 into SeleniumHQ:trunk Mar 29, 2025
    9 of 10 checks passed
    @nvborisenko nvborisenko deleted the bidi-get-client-window branch March 29, 2025 16:25
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    1 participant