[dotnet] [bidi] Make ProxyConfiguration as not nested

[nvborisenko]

User description

Motivation and Context

Contributes to #15407

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Enhancement

---

Description

• Refactored ProxyConfiguration to use non-nested types.

• Updated derived types to standalone records.

• Improved naming consistency for proxy configuration types.

---

Changes walkthrough 📝

Relevant files

Enhancement

ProxyConfiguration.cs Refactor `ProxyConfiguration` to standalone record types  dotnet/src/webdriver/BiDi/Modules/Session/ProxyConfiguration.cs Refactored ProxyConfiguration to remove nested record types. Introduced standalone records for proxy configurations. Updated type discriminator attributes for new record names. Improved maintainability and extensibility of proxy configuration types. +19/-20

---

Need help?

Type /help how to ... in the comments thread for any questions about Qodo Merge usage.

Check out the documentation for more information.

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅ 15407 - PR Code Verified Compliant requirements: • Don't use nested DTO types in the .NET implementation • Move from nested types to standalone types • Improve naming consistency Requires further human verification: • Verify that all nested types across the codebase have been identified and refactored (this PR only shows ProxyConfiguration)

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Naming Convention The new type names follow a consistent pattern by appending "ProxyConfiguration" to each type, but this might be redundant. Consider if shorter names like "AutoDetectProxy" would be more idiomatic. public record AutoDetectProxyConfiguration : ProxyConfiguration; public record DirectProxyConfiguration : ProxyConfiguration; public record ManualProxyConfiguration : ProxyConfiguration { public string? FtpProxy { get; set; } public string? HttpProxy { get; set; } public string? SslProxy { get; set; } public string? SocksProxy { get; set; } public long? SocksVersion { get; set; } } public record PacProxyConfiguration(string ProxyAutoConfigUrl) : ProxyConfiguration; public record SystemProxyConfiguration : ProxyConfiguration;

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
General	Maintain consistent property pattern The PacProxyConfiguration record uses a positional parameter which doesn't match the property-based pattern used in other configuration classes like ManualProxyConfiguration. Consider using a property-based approach for consistency. dotnet/src/webdriver/BiDi/Modules/Session/ProxyConfiguration.cs [49] -public record PacProxyConfiguration(string ProxyAutoConfigUrl) : ProxyConfiguration; +public record PacProxyConfiguration : ProxyConfiguration +{ + public string ProxyAutoConfigUrl { get; set; } = string.Empty; +} Apply this suggestion Suggestion importance[1-10]: 7 __ Why: The suggestion improves code consistency by changing PacProxyConfiguration from using a positional parameter to a property-based pattern that matches the style used in other configuration classes. This enhances maintainability and readability of the codebase.	Medium
More

[RenderMichael]

Nice and simple