Skip to content

Conversation

sandeepsuryaprasad
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixed a typo error in _TimeoutsDescriptor in common/options.py.

Motivation and Context

In __get__ method of _TimeoutsDescriptor in common/options.py, instead of obj._caps, by mistake it was self._caps which was causing AttributeError when I tried to look-up for attribute page_load_strategy. I have fixed it.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (72f083c) 57.26% compared to head (0f5d1af) 57.26%.
Report is 1 commits behind head on trunk.

❗ Current head 0f5d1af differs from pull request most recent head b586195. Consider uploading reports for the commit b586195 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@ Coverage Diff @@ ## trunk #12499 +/- ## ======================================= Coverage 57.26% 57.26% ======================================= Files 86 86 Lines 5335 5335 Branches 198 198 ======================================= Hits 3055 3055 Misses 2082 2082 Partials 198 198 
Files Changed Coverage Δ
py/selenium/webdriver/common/options.py 34.31% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sandeepsuryaprasad
Copy link
Contributor Author

@diemol looks like some tests are failing in remote which are not related to the changes that I have made.

@titusfortner titusfortner merged commit 937920d into SeleniumHQ:trunk Aug 14, 2023
@sandeepsuryaprasad sandeepsuryaprasad deleted the chrome-options-fix branch November 24, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants