Skip to content

[dotnet] Avoid async void events in CDP Network session #12486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2023
Merged

[dotnet] Avoid async void events in CDP Network session #12486

merged 3 commits into from
Aug 14, 2023

Conversation

nvborisenko
Copy link
Member

Description

async void is not good approach - unhandled exceptions will crash entire app.

Motivation and Context

Fixes #12480

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
@diemol
Copy link
Member

diemol commented Aug 4, 2023

Build is failing.
@titusfortner titusfortner added this to the 4.12 milestone Aug 14, 2023
@titusfortner titusfortner merged commit 074e7c8 into SeleniumHQ:trunk Aug 14, 2023
@titusfortner
Copy link
Member

I'm so glad we fixed the .NET build finally 😂
@nvborisenko nvborisenko deleted the avoid-async-void branch August 22, 2023 19:06
@nvborisenko nvborisenko mentioned this pull request Sep 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@nvborisenko @diemol @titusfortner