[dotnet] Fix continueResponse method in CDP #12445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Is there a test we can add to show it failing/passing? |
| Most likely only for cdp v115 (as the latest, I didn't find tests for others). |
| Yes yes, we only test the version that is on the CI... |
| No, it is supposed to be used by https://github.com/SeleniumHQ/selenium/blob/trunk/dotnet/src/webdriver/NetworkManager.cs which is not even covered by unit tests. Given that BiDi is our primary goal, I have no motivation to create tests for features nobody is using (or usage of it is blocked by #12431) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Looks like this code was wrote by a mistake.
Types of changes
Checklist