Skip to content

[dotnet] Fallback result parsing of script execution to expected type #11930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2023
Merged

[dotnet] Fallback result parsing of script execution to expected type #11930

merged 2 commits into from
Apr 24, 2023

Conversation

nvborisenko
Copy link
Member

Description

Executing JS in browser may return result of different types. I have added new conditional thread to try casting of result to expected type.

It is not a breaking change, this change can be considered as "now trying one more way".

Motivation and Context

Fixes #11801

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
diemol
diemol approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nvborisenko!
@diemol diemol merged commit 79e3f9e into SeleniumHQ:trunk Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@nvborisenko @diemol