[rust] Use static linking using cross-compiling to target x86_64-unknown-linux-musl in GH Actions #11749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
diemol approved these changes Mar 9, 2023
alpatron pushed a commit to alpatron/selenium that referenced this pull request Mar 15, 2023
…own-linux-musl in GH Actions (SeleniumHQ#11749) * [rust] Compile selenium-manager using x86_64-unknown-linux-musl target in Linux * [rust] Change way to install cargo-zigbuild * [rust] Remove zibguild * [rust] Install cargo-zigbuild again * [rust] Disable crt-static * [rust] Install zip in Linux * [rust] Remove debugging symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the default cargo target on GH Actions for Linux, from
x86_64-unknown-linux-gnutox86_64-unknown-linux-musl. This target should ensure static linking in selenium-manager binaries for Linux. Cross-compiling in GH Actions is done through cargo-zigbuild.Motivation and Context
This PR should prevent issues like #11717.
Types of changes
Checklist