[grid] improved exception handling when no cause is set #11286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportBase: 52.69% // Head: 52.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@ ## trunk #11286 +/- ## ======================================= Coverage 52.69% 52.69% ======================================= Files 82 82 Lines 5545 5545 Branches 198 198 ======================================= Hits 2922 2922 Misses 2425 2425 Partials 198 198 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
In cases where the exception thrown has no cause there was no helpful stack trace to localize the issue.
diemol force-pushed the grid-null-cause branch from 81c884d to 4e1b7b6 Compare 
| Kudos, SonarCloud Quality Gate passed! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
In cases where the exception thrown has no cause there was no helpful stack trace to localize the issue.
Motivation and Context
I was playing with another PR and added a
ImmutableMap.of("value", null)call, this lead to an exception without cause set. I was not able to get the origin in code of the exception due to the missing infos in the server answer.Types of changes
Checklist