Skip to content

Conversation

@stefanloerwald
Copy link
Contributor

I performed a cleanup of the code base

  • typos
  • async issues
  • renames that went wrong
  • unused methods
  • properties that can be auto properties
  • missing curly braces for clarity
  • switch statements that are more readable as switch expressions
  • inconsistent line breaks (crlf vs lf)
@lindespang
Copy link
Collaborator

@stefanloerwald Gods work, thanks. See comment I made on the commit.

By the way, I definitely think we should remove all commented out code from the repo. My eyes are bleeding when I see it, we have version control for a reason ;- ) But that could maybe be saved for a rainy day.

@lindespang
Copy link
Collaborator

@stefanloerwald Nice job, thanks for this!

@lindespang lindespang merged commit 2e619bf into SamProf:develop Aug 6, 2020
@stefanloerwald stefanloerwald deleted the cleanup branch August 6, 2020 13:10
SamProf added a commit that referenced this pull request Sep 5, 2020
- PR: Cleanup #673 (Thanks to [stefanloerwald](https://github.com/stefanloerwald)) - PR: Table Re-Rendering Fix #692 (Thanks to [erlendp](https://github.com/erlendp)) - PR: Custom Drawer Width Demo. Readme contribution updates #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants