Skip to content

Return Object.class from Instances#getType instead of throwing an exc… #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 22, 2016
Merged

Return Object.class from Instances#getType instead of throwing an exc… #162

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec84519
Return Object.class from Instances#getType instead of throwing an exc…
jlsalmon Jun 6, 2016
c173daf
Add a debug message when comparing instances of different types
jlsalmon Jun 9, 2016
8c99190
Fixed intentation
jlsalmon Jun 9, 2016
fa656e9
Improved debug message
jlsalmon Jun 20, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed intentation
  • Loading branch information
@jlsalmon
jlsalmon committed Jun 9, 2016
commit 8c99190b67744384b0a7fe7196d3b80e8599b709
2 changes: 1 addition & 1 deletion src/main/java/de/danielbechler/diff/access/Instances.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ else if (sourceAccessorType != null)
}

logger.info("Detected instances of different types " + types + ". " +
"Instances should normally either be null or have the exact same type.");
"Instances should normally either be null or have the exact same type.");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good. Maybe replace "Instances should normally either be null or have the exact same type" with something along the lines of "These objects will only be compared via equals method".
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!
return Object.class;
}

Expand Down