Fix AnimatedImage scale logic to match SwiftUI.Image #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…mpared with SwiftUI.Image
… since it return some View but not AnimatedImage
…which default size more correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
in #34 this PR, the contentMode (aspectFill) is ignored, so sometimes, the AnimatedImage may not layout as expected compared to Image.
This PR fix that, using the correct behavior as Image (base on Documentation and real behavior).
Note that
.fit && aspectRatio == nilon macOS may not work exact the same as SwiftUI.Image because of limitation of public API, other cases and platform as matched.