update Published properties of ImageManager in the main thread #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I have a same issue on screen with dynamic list of images, thanks! iOS 16.0 only |
| I don't think this fix is correct. See #232, which dispatch the onAppear in correct timing |
| Since the #232 do the similiar things (It dispatch the The feature is embed into that PR. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
update
Publishedproperties ofImageManagerin the main threadWhy?
Publishing changes from background threads is not allowed; make sure to publish values from the main thread.
How?
As a temporary solution, enforcing assigning new values in the main thread but ideally it should be done via subscription to model changes and triggering changes as e response. i.e. via PassthroughSubject and operators like receive(on:)).