Text Assembly: allow for multiple line assembly #598
Merged
+43 −6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
bjoern-jueliger-sap requested changes Jul 25, 2023
Comment on lines 46 to 50
| IF previous_row IS NOT INITIAL | ||
| AND <token>-row > previous_row | ||
| AND <token>-str = '|'. | ||
| multiple_lines = abap_true. | ||
| ENDIF. |
There was a problem hiding this comment.
This assumes that in "multi-line strings" the first token of the next row will always be the `|``. But we can also have this:
data(str) = |this is a very long string with some { placeholder }| && |and this is the rest of the string with another { placeholder }|.I think we need to separately track "is there a | used here?" and "is there a linebreak in here?" as two booleans and if both are true, then no finding should be emitted.
There was a problem hiding this comment.
Thanks @bjoern-jueliger-sap, just pushed a change to do this.
bjoern-jueliger-sap approved these changes Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Open to feedback here, this case didn't fit the framework quite as cleanly as I would have liked.